github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use InternalCallbackScope for ticking event loop

Browse Source
This commit is contained in:
Cheng Zhao
2018-03-09 14:54:25 +09:00
parent 50a5a69c46
commit 5d2452608d
3 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
atom/common/api/atom_bindings.cc
View File

@@ -97,16 +97,11 @@ void AtomBindings::OnCallNextTick(uv_async_t* handle) {
for (std::list<node::Environment*>::const_iterator it =
self->pending_next_ticks_.begin();
it != self->pending_next_ticks_.end(); ++it) {
node::Environment* env = *it;
// KickNextTick, copied from node.cc:
node::Environment::AsyncCallbackScope callback_scope(env);
if (callback_scope.in_makecallback())
continue;
node::Environment::TickInfo* tick_info = env->tick_info();
if (!tick_info->has_scheduled())
env->isolate()->RunMicrotasks();
v8::Local<v8::Object> process = env->process_object();
env->tick_callback_function()->Call(process, 0, nullptr).IsEmpty();
node::InternalCallbackScope scope(
*it,
v8::Local<v8::Object>(),
{0, 0},
node::InternalCallbackScope::kAllowEmptyResource);
}
self->pending_next_ticks_.clear();