github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't destroy BrowserView webContents when owning BrowserWindow hasn't been closed (#42353)

Browse Source 
* fix: moves bv webContents close to closed event

* chore: adds unit tests

* chore: test that bv webContents are destroyed when parent bw closed
This commit is contained in:
Anny Yang
2024-06-05 00:58:38 -07:00
committed by GitHub
parent 39c984e23a
commit 5fb117a7d7
2 changed files with 54 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/browser/api/browser-window.ts
View File

@@ -77,7 +77,7 @@ BrowserWindow.prototype._init = function (this: BWT) {
this._browserViews = [];
this.on('close', () => {
this.on('closed', () => {
this._browserViews.forEach(b => b.webContents?.close({ waitForBeforeUnload: true }));
});