From 62d2a3472fc597143b9b2b387df4861434191be1 Mon Sep 17 00:00:00 2001 From: Nitish Sakhawalkar Date: Fri, 2 Feb 2018 18:31:02 -0800 Subject: [PATCH] Fix test BrowserWindow.addTabbedWindow() (#11795) * Fix test BrowserWindow.addTabbedWindow() * Address review comments --- spec/api-browser-window-spec.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index 195e94f39b..be72b25dd6 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -703,8 +703,7 @@ describe('BrowserWindow module', () => { }) }) - // FIXME(alexeykuzmin): Fails on Mac. - xdescribe('BrowserWindow.addTabbedWindow()', () => { + describe('BrowserWindow.addTabbedWindow()', () => { before(function () { if (process.platform !== 'darwin') { this.skip() @@ -716,7 +715,13 @@ describe('BrowserWindow module', () => { assert.doesNotThrow(() => { w.addTabbedWindow(tabbedWindow) }) - closeWindow(tabbedWindow).then(done) + + assert.equal(BrowserWindow.getAllWindows().length, 3) // Test window + w + tabbedWindow + + closeWindow(tabbedWindow, {assertSingleWindow: false}).then(() => { + assert.equal(BrowserWindow.getAllWindows().length, 2) // Test window + w + done() + }) }) })