github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove DevTools legacy UI patching (#40331)

Browse Source
This commit is contained in:
Shelley Vohr
2023-10-26 14:36:04 -04:00
committed by GitHub
parent 30fbcfca7b
commit 652f995128
6 changed files with 35 additions and 327 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
spec/extensions-spec.ts
View File

@@ -573,10 +573,11 @@ describe('chrome extensions', () => {
const showLastPanel = () => {
// this is executed in the devtools context, where UI is a global
const { UI } = (window as any);
const tabs = UI.InspectorView.instance().tabbedPane.tabs;
const { EUI } = (window as any);
const instance = EUI.InspectorView.InspectorView.instance();
const tabs = instance.tabbedPane.tabs;
const lastPanelId = tabs[tabs.length - 1].id;
UI.InspectorView.instance().showPanel(lastPanelId);
instance.showPanel(lastPanelId);
};
devToolsWebContents.executeJavaScript(`(${showLastPanel})()`, false).then(() => {
showPanelTimeoutId = setTimeout(show, 100);

7
spec/webview-spec.ts
View File

@@ -297,10 +297,11 @@ describe('<webview> tag', function () {
const showPanelIntervalId = setInterval(function () {
if (!webContents.isDestroyed() && webContents.devToolsWebContents) {
webContents.devToolsWebContents.executeJavaScript('(' + function () {
const { UI } = (window as any);
const tabs = UI.InspectorView.instance().tabbedPane.tabs;
const { EUI } = (window as any);
const instance = EUI.InspectorView.InspectorView.instance();
const tabs = instance.tabbedPane.tabs;
const lastPanelId: any = tabs[tabs.length - 1].id;
UI.InspectorView.instance().showPanel(lastPanelId);
instance.showPanel(lastPanelId);
}.toString() + ')()');
} else {
clearInterval(showPanelIntervalId);