fix: chrome.tabs.update return value (#39389)

fix: chrome.tabs.update return value

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This commit is contained in:
trop[bot]
2023-08-07 12:38:19 +02:00
committed by GitHub
parent 4586a40bfd
commit 66f42b3256
4 changed files with 43 additions and 0 deletions

View File

@@ -931,6 +931,23 @@ describe('chrome extensions', () => {
expect(response.status).to.equal('reloaded');
});
});
it('update', async () => {
await w.loadURL(url);
const message = { method: 'update', args: [{ muted: true }] };
w.webContents.executeJavaScript(`window.postMessage('${JSON.stringify(message)}', '*')`);
const [,, responseString] = await once(w.webContents, 'console-message');
const response = JSON.parse(responseString);
expect(response).to.have.property('mutedInfo').that.is.a('object');
const { mutedInfo } = response;
expect(mutedInfo).to.deep.eq({
muted: true,
reason: 'user'
});
});
});
});
});

View File

@@ -42,6 +42,13 @@ const handleRequest = (request, sender, sendResponse) => {
chrome.tabs.reload(tabId).then(() => {
sendResponse({ status: 'reloaded' });
});
break;
}
case 'update': {
const [params] = args;
chrome.tabs.update(tabId, params).then(sendResponse);
break;
}
}
};

View File

@@ -34,6 +34,11 @@ const testMap = {
chrome.runtime.sendMessage({ method: 'reload' }, response => {
console.log(JSON.stringify(response));
});
},
update (params) {
chrome.runtime.sendMessage({ method: 'update', args: [params] }, response => {
console.log(JSON.stringify(response));
});
}
};