github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: respect LogJsConsoleMessages feature in InspectableWebContents::DidAddMessageToConsole (#30356)

Browse Source 
* fix: respect LogJsConsoleMessages feature in InspectableWebContents::DidAddMessageToConsole

* just delete the method

Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
This commit is contained in:
trop[bot]
2021-08-02 10:00:30 +09:00
committed by GitHub
parent d462204dce
commit 6765eec7a9
2 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
shell/browser/ui/inspectable_web_contents.cc
View File

@@ -971,20 +971,6 @@ void InspectableWebContents::WebContentsDestroyed() {
view_->GetDelegate()->DevToolsClosed();
}
bool InspectableWebContents::DidAddMessageToConsole(
content::WebContents* source,
blink::mojom::ConsoleMessageLevel level,
const std::u16string& message,
int32_t line_no,
const std::u16string& source_id) {
logging::LogMessage("CONSOLE", line_no,
blink::ConsoleMessageLevelToLogSeverity(level))
.stream()
<< "\"" << message << "\", source: " << source_id << " (" << line_no
<< ")";
return true;
}
bool InspectableWebContents::HandleKeyboardEvent(
content::WebContents* source,
const content::NativeWebKeyboardEvent& event) {

5
shell/browser/ui/inspectable_web_contents.h
View File

@@ -175,11 +175,6 @@ class InspectableWebContents
content::NavigationHandle* navigation_handle) override;
// content::WebContentsDelegate:
bool DidAddMessageToConsole(content::WebContents* source,
blink::mojom::ConsoleMessageLevel level,
const std::u16string& message,
int32_t line_no,
const std::u16string& source_id) override;
bool HandleKeyboardEvent(content::WebContents*,
const content::NativeWebKeyboardEvent&) override;
void CloseContents(content::WebContents* source) override;