From 68098c317f772f9d9b8327b7f4be98e66b70f5c9 Mon Sep 17 00:00:00 2001 From: John Kleinschmidt Date: Mon, 25 Aug 2025 16:46:36 -0400 Subject: [PATCH] build: remove no longer needed arg for siso (#48164) * build: remove no longer needed arg for siso * chore: test ffmpeg zip * build: fix ffmpeg build with siso * Revert "chore: test ffmpeg zip" This reverts commit 2bbcc86039eca435b4ab9ced6fd59f761fee2fd5. --- .github/actions/build-electron/action.yml | 2 +- build/args/all.gn | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/actions/build-electron/action.yml b/.github/actions/build-electron/action.yml index 5656aff2cb..58e43cfe05 100644 --- a/.github/actions/build-electron/action.yml +++ b/.github/actions/build-electron/action.yml @@ -202,7 +202,7 @@ runs: if: ${{ inputs.is-release == 'true' }} run: | cd src - gn gen out/ffmpeg --args="import(\"//electron/build/args/ffmpeg.gn\") use_remoteexec=true $GN_EXTRA_ARGS" + gn gen out/ffmpeg --args="import(\"//electron/build/args/ffmpeg.gn\") use_remoteexec=true use_siso=true $GN_EXTRA_ARGS" e build --target electron:electron_ffmpeg_zip -C ../../out/ffmpeg - name: Generate Hunspell Dictionaries ${{ inputs.step-suffix }} shell: bash diff --git a/build/args/all.gn b/build/args/all.gn index 3d1866d45f..fdeb59e8b5 100644 --- a/build/args/all.gn +++ b/build/args/all.gn @@ -69,7 +69,3 @@ v8_expose_public_symbols = true # Disable snapshotting a page when printing for its content to be analyzed for # sensitive content by enterprise users. enterprise_cloud_content_analysis = false - -# Disable siso until we are ready to use it. -# https://chromium-review.googlesource.com/c/chromium/src/+/6638830 -use_siso = false