diff --git a/patches/v8/.patches b/patches/v8/.patches index d4cee9c7f2..6abadfe676 100644 --- a/patches/v8/.patches +++ b/patches/v8/.patches @@ -1,5 +1,4 @@ build_gn.patch -expose_mksnapshot.patch dcheck.patch export_symbols_needed_for_windows_build.patch do_not_export_private_v8_symbols_on_windows.patch diff --git a/patches/v8/build_gn.patch b/patches/v8/build_gn.patch index 3b51c1e81f..ae4343dde6 100644 --- a/patches/v8/build_gn.patch +++ b/patches/v8/build_gn.patch @@ -6,10 +6,10 @@ Subject: build_gn.patch We force V8 into 'shared library' mode so that it exports its symbols, which is necessary for native modules to load. -Also, some fixes relating to mksnapshot on ARM. +Also change visibility on mksnapshot in order to target mksnapshot for mksnapshot zip. diff --git a/BUILD.gn b/BUILD.gn -index d75f44b55a89828845f69f148da147ea29d523e2..4b90367b6a73503ae44c0a68c23d7a2fd606135c 100644 +index d75f44b55a89828845f69f148da147ea29d523e2..3140abb0868eb81976edacafc625bc80159b5aea 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -714,7 +714,7 @@ config("internal_config") { @@ -30,3 +30,11 @@ index d75f44b55a89828845f69f148da147ea29d523e2..4b90367b6a73503ae44c0a68c23d7a2f deps = [ ":v8_libbase", +@@ -6475,7 +6475,6 @@ if (current_toolchain == v8_generator_toolchain) { + + if (current_toolchain == v8_snapshot_toolchain) { + v8_executable("mksnapshot") { +- visibility = [ ":*" ] # Only targets in this file can depend on this. + + sources = [ + "src/snapshot/embedded/embedded-empty.cc", diff --git a/patches/v8/expose_mksnapshot.patch b/patches/v8/expose_mksnapshot.patch deleted file mode 100644 index 9d5824fbfe..0000000000 --- a/patches/v8/expose_mksnapshot.patch +++ /dev/null @@ -1,19 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Shelley Vohr -Date: Mon, 22 Oct 2018 10:47:13 -0700 -Subject: expose_mksnapshot.patch - -Needed in order to target mksnapshot for mksnapshot zip. - -diff --git a/BUILD.gn b/BUILD.gn -index 4b90367b6a73503ae44c0a68c23d7a2fd606135c..3140abb0868eb81976edacafc625bc80159b5aea 100644 ---- a/BUILD.gn -+++ b/BUILD.gn -@@ -6475,7 +6475,6 @@ if (current_toolchain == v8_generator_toolchain) { - - if (current_toolchain == v8_snapshot_toolchain) { - v8_executable("mksnapshot") { -- visibility = [ ":*" ] # Only targets in this file can depend on this. - - sources = [ - "src/snapshot/embedded/embedded-empty.cc",