github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-02-15 01:25:00 -05:00
Code Issues Packages Projects Releases Wiki Activity

ci: make sure mksnapshot is invoked with proper args. (#21991)

Browse Source 
* build: robustify verify-mksnapshot w.r.t. command-line parameters

Co-authored-by: Jeremy Apthorp <nornagon@nornagon.net>
This commit is contained in:
John Kleinschmidt
2020-02-04 13:10:11 -05:00
committed by GitHub
parent 6273bc9957
commit 6f1f4d3f2f
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
script/verify-mksnapshot.py
View File

@@ -26,12 +26,9 @@ def main():
try:
with scoped_cwd(app_path):
if args.snapshot_files_dir is None:
mkargs = [ get_binary_path('mksnapshot', app_path), \
SNAPSHOT_SOURCE, '--startup_blob', 'snapshot_blob.bin', \
'--no-native-code-counters', '--turbo_instruction_scheduling' ]
if get_target_arch() == 'ia32':
mkargs.append('--target_arch=x86')
subprocess.check_call(mkargs)
with open(os.path.join(app_path, 'mksnapshot_args')) as f:
mkargs = f.read().splitlines()
subprocess.check_call(mkargs + [ SNAPSHOT_SOURCE ], cwd=app_path)
print('ok mksnapshot successfully created snapshot_blob.bin.')
context_snapshot = 'v8_context_snapshot.bin'
context_snapshot_path = os.path.join(app_path, context_snapshot)