From 731240e0e949c67bbb3175907bbc8f813530760b Mon Sep 17 00:00:00 2001
From: Samuel Attard <samuel.r.attard@gmail.com>
Date: Thu, 15 Feb 2018 13:07:49 +1100
Subject: [PATCH] Use USER_WANTS_NO_MORE_DIALOGS constant for -1 magic number

---
 atom/browser/atom_javascript_dialog_manager.cc | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/atom/browser/atom_javascript_dialog_manager.cc b/atom/browser/atom_javascript_dialog_manager.cc
index f29a3d9926..219b297314 100644
--- a/atom/browser/atom_javascript_dialog_manager.cc
+++ b/atom/browser/atom_javascript_dialog_manager.cc
@@ -17,6 +17,10 @@
 
 using content::JavaScriptDialogType;
 
+namespace {
+  constexpr int USER_WANTS_NO_MORE_DIALOGS = -1;
+}
+
 namespace atom {
 
 AtomJavaScriptDialogManager::AtomJavaScriptDialogManager(
@@ -36,7 +40,7 @@ void AtomJavaScriptDialogManager::RunJavaScriptDialog(
     origin_counts_[origin] = 0;
   }
 
-  if (origin_counts_[origin] == -1) {
+  if (origin_counts_[origin] == USER_WANTS_NO_MORE_DIALOGS) {
     return callback.Run(false, base::string16());
   }
 
@@ -92,7 +96,7 @@ void AtomJavaScriptDialogManager::OnMessageBoxCallback(
     int code,
     bool checkbox_checked) {
   if (checkbox_checked) {
-    (*origin_counts_)[origin] = -1;
+    (*origin_counts_)[origin] = USER_WANTS_NO_MORE_DIALOGS;
   }
   callback.Run(code == 0, base::string16());
 }