github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: native View wrapper crash missing when adding child view (#43638)

Browse Source 
fix: native View wrapper crash missing when adding child view
This commit is contained in:
Shelley Vohr
2024-09-12 10:01:05 +02:00
committed by GitHub
parent dea6a4e5fb
commit 74b54278bf
3 changed files with 29 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
shell/browser/ui/cocoa/delayed_native_view_host.mm
View File

@@ -15,13 +15,9 @@ DelayedNativeViewHost::~DelayedNativeViewHost() = default;
void DelayedNativeViewHost::ViewHierarchyChanged(
const views::ViewHierarchyChangedDetails& details) {
// NativeViewHost doesn't expect to have children, so filter the
// ViewHierarchyChanged events before passing them on.
if (details.child == this) {
NativeViewHost::ViewHierarchyChanged(details);
if (details.is_add && GetWidget() && !native_view())
Attach(native_view_);
}
NativeViewHost::ViewHierarchyChanged(details);
if (details.is_add && GetWidget() && !native_view())
Attach(native_view_);
}
bool DelayedNativeViewHost::OnMousePressed(const ui::MouseEvent& ui_event) {