fix: strip branded binaries (#36656)

When creating branded release builds and using scripts/strip-binaries.py
on Linux, the final artifacts end up unstripped due to the static set of
binaries considered for stripping.
With this patch the name of the electron binary is taken from the
BRANDING.json `project_name` key.

Signed-off-by: Robert Günzler <r@gnzler.io>

Co-authored-by: Robert Günzler <r@gnzler.io>

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Robert Günzler <r@gnzler.io>
This commit is contained in:
trop[bot]
2022-12-14 11:50:53 -05:00
committed by GitHub
parent bb9badc41a
commit 74d5ddcd28
5 changed files with 20 additions and 19 deletions

View File

@@ -13,16 +13,6 @@ PLATFORM = {
'win32': 'win32',
}[sys.platform]
LINUX_BINARIES = [
'chrome-sandbox',
'chrome_crashpad_handler',
'electron',
'libEGL.so',
'libGLESv2.so',
'libffmpeg.so',
'libvk_swiftshader.so',
]
verbose_mode = False

View File

@@ -215,3 +215,14 @@ def get_buildtools_executable(name):
if sys.platform == 'win32':
path += '.exe'
return path
def get_linux_binaries():
return [
'chrome-sandbox',
'chrome_crashpad_handler',
get_electron_branding()['project_name'],
'libEGL.so',
'libGLESv2.so',
'libffmpeg.so',
'libvk_swiftshader.so',
]