github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-10 16:08:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove last use of InternalCallbackScope (#27029)

Browse Source 
* refactor: remove last use of InternalCallbackScope

* update patches

Co-authored-by: Electron Bot <electron@github.com>
This commit is contained in:
Shelley Vohr
2020-12-16 12:02:36 -08:00
committed by GitHub
parent 9377b04e0b
commit 75247d18d0
5 changed files with 4 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
shell/app/node_main.cc
View File

@@ -206,7 +206,7 @@ int NodeMain(int argc, char* argv[]) {
exec_argv + exec_argc); // NOLINT
env = node::CreateEnvironment(isolate_data, gin_env.context(), args,
exec_args);
CHECK_NE(nullptr, env);
CHECK_NOT_NULL(env);
node::IsolateSettings is;
node::SetIsolateUpForNode(isolate, is);
@@ -239,14 +239,8 @@ int NodeMain(int argc, char* argv[]) {
}
}
// TODO(codebytere): we should try to handle this upstream.
{
v8::HandleScope scope(isolate);
node::InternalCallbackScope callback_scope(
env, v8::Object::New(isolate), {1, 0},
node::InternalCallbackScope::kSkipAsyncHooks);
node::LoadEnvironment(env);
}
v8::HandleScope scope(isolate);
node::LoadEnvironment(env);
env->set_trace_sync_io(env->options()->trace_sync_io);