github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: natively promisify WebContents.prototype.takeHeapSnapshot (#18000)

Browse Source
This commit is contained in:
Milan Burda
2019-04-29 19:11:11 +02:00
committed by Jeremy Apthorp
parent 18b77a4de6
commit 7574f91f31
3 changed files with 22 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/browser/api/web-contents.js
View File

@@ -226,18 +226,6 @@ WebContents.prototype.getZoomFactor = function (callback) {
}
}
WebContents.prototype.takeHeapSnapshot = function (filePath) {
return new Promise((resolve, reject) => {
this._takeHeapSnapshot(filePath, (success) => {
if (success) {
resolve()
} else {
reject(new Error('takeHeapSnapshot failed'))
}
})
})
}
// Translate the options of printToPDF.
WebContents.prototype.printToPDF = function (options) {
const printingSetting = Object.assign({}, defaultPrintingSetting)