From 767a178bd1d84d0e94de9626395c600ddd0dc889 Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Tue, 10 Oct 2017 03:18:44 +1100 Subject: [PATCH] Do not throw if the named image can not be found --- atom/common/api/atom_api_native_image.cc | 1 - atom/common/api/atom_api_native_image_mac.mm | 1 - 2 files changed, 2 deletions(-) diff --git a/atom/common/api/atom_api_native_image.cc b/atom/common/api/atom_api_native_image.cc index 419a6c6a61..79ec0c4b60 100644 --- a/atom/common/api/atom_api_native_image.cc +++ b/atom/common/api/atom_api_native_image.cc @@ -544,7 +544,6 @@ mate::Handle NativeImage::CreateFromDataURL( #if !defined(OS_MACOSX) mate::Handle NativeImage::CreateFromNamedImage( mate::Arguments* args, const std::string& name) { - args->ThrowError("Cannot create NativeImage from a name on non-darwin platforms"); return CreateEmpty(args->isolate()); } #endif diff --git a/atom/common/api/atom_api_native_image_mac.mm b/atom/common/api/atom_api_native_image_mac.mm index d19a580dcf..d9665ceabe 100644 --- a/atom/common/api/atom_api_native_image_mac.mm +++ b/atom/common/api/atom_api_native_image_mac.mm @@ -17,7 +17,6 @@ mate::Handle NativeImage::CreateFromNamedImage( @autoreleasepool { NSImage* image = [NSImage imageNamed:base::SysUTF8ToNSString(name)]; if (!image.valid) { - args->ThrowError("Cannot create image from name: " + name); return CreateEmpty(args->isolate()); }