github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-10 07:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: stack traces in non-Node.js contexts (#26820)

Browse Source
This commit is contained in:
Shelley Vohr
2020-12-09 11:08:13 -08:00
committed by GitHub
parent 1a79bedb27
commit 76f721474e
3 changed files with 52 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
shell/common/node_bindings.cc
View File

@@ -503,6 +503,13 @@ node::Environment* NodeBindings::CreateEnvironment(
// context. We need to use the one Blink already provides.
is.flags |=
node::IsolateSettingsFlags::SHOULD_NOT_SET_PROMISE_REJECTION_CALLBACK;
// We do not want to use the stack trace callback that Node.js uses,
// because it relies on Node.js being aware of the current Context and
// that's not always the case. We need to use the one Blink already
// provides.
is.flags |=
node::IsolateSettingsFlags::SHOULD_NOT_SET_PREPARE_STACK_TRACE_CALLBACK;
}
node::SetIsolateUpForNode(context->GetIsolate(), is);