github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't run environment bootstrapper (#22342)

Browse Source
This commit is contained in:
Shelley Vohr
2020-02-25 16:46:08 +00:00
committed by GitHub
parent 2aa734385e
commit 79270e30a6
14 changed files with 79 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
shell/app/node_main.cc
View File

@@ -142,17 +142,14 @@ int NodeMain(int argc, char* argv[]) {
node::CreateIsolateData(gin_env.isolate(), loop, gin_env.platform());
CHECK_NE(nullptr, isolate_data);
node::Environment* env =
node::CreateEnvironment(isolate_data, gin_env.context(), argc, argv,
exec_argc, exec_argv, false);
node::Environment* env = node::CreateEnvironment(
isolate_data, gin_env.context(), argc, argv, exec_argc, exec_argv);
CHECK_NE(nullptr, env);
// Enable support for v8 inspector.
NodeDebugger node_debugger(env);
node_debugger.Start();
node::BootstrapEnvironment(env);
// TODO(codebytere): we shouldn't have to call this - upstream?
env->InitializeDiagnostics();