From 792dc5d1e27979bf794ebbd49fd7022ddd3dbac9 Mon Sep 17 00:00:00 2001 From: deepak1556 Date: Thu, 4 Dec 2025 12:56:01 +0900 Subject: [PATCH] chore: rm fix_export_zlib_symbols.patch in favor of gn argument --- build/args/all.gn | 3 +++ patches/chromium/.patches | 1 - .../chromium/fix_export_zlib_symbols.patch | 22 ------------------- 3 files changed, 3 insertions(+), 23 deletions(-) delete mode 100644 patches/chromium/fix_export_zlib_symbols.patch diff --git a/build/args/all.gn b/build/args/all.gn index b62e24774d..740a3d5cf6 100644 --- a/build/args/all.gn +++ b/build/args/all.gn @@ -75,3 +75,6 @@ enable_linux_installer = false # Disable "Save to Drive" feature in PDF viewer enable_pdf_save_to_drive = false + +# Export zlib symbols for native modules +zlib_symbols_visible = true diff --git a/patches/chromium/.patches b/patches/chromium/.patches index 5881ab1840..ef6a4056f0 100644 --- a/patches/chromium/.patches +++ b/patches/chromium/.patches @@ -53,7 +53,6 @@ worker_feat_add_hook_to_notify_script_ready.patch chore_provide_iswebcontentscreationoverridden_with_full_params.patch fix_properly_honor_printing_page_ranges.patch export_gin_v8platform_pageallocator_for_usage_outside_of_the_gin.patch -fix_export_zlib_symbols.patch web_contents.patch webview_fullscreen.patch extend_apply_webpreferences.patch diff --git a/patches/chromium/fix_export_zlib_symbols.patch b/patches/chromium/fix_export_zlib_symbols.patch deleted file mode 100644 index 39d76d3b68..0000000000 --- a/patches/chromium/fix_export_zlib_symbols.patch +++ /dev/null @@ -1,22 +0,0 @@ -From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 -From: Shelley Vohr -Date: Mon, 1 Jun 2020 15:30:47 -0800 -Subject: fix: export zlib symbols - -This patch sets ZLIB_DLL so that we properly export zlib symbols. - -diff --git a/third_party/zlib/BUILD.gn b/third_party/zlib/BUILD.gn -index afd3e8cc0f38e95b3b04835b46bd1197a63b4ed1..652fa32d49de9f0c73777c0d4d99421f52e16b38 100644 ---- a/third_party/zlib/BUILD.gn -+++ b/third_party/zlib/BUILD.gn -@@ -333,6 +333,10 @@ component("zlib") { - defines = [] - deps = [] - -+ if (is_win) { -+ defines += [ "ZLIB_DLL" ] -+ } -+ - if (!use_x86_x64_optimizations && !use_arm_neon_optimizations) { - # Apparently android_cronet bot builds with NEON disabled and - # we also should disable optimizations for iOS@x86 (a.k.a. simulator).