github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-10 07:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

chore: use std::make_unique/base::MakeRefCounted when possible (#29510)

Browse Source
This commit is contained in:
David Sanders
2021-06-07 19:00:05 -07:00
committed by GitHub
parent a4decffe9a
commit 79cb5144ae
38 changed files with 106 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
shell/renderer/api/electron_api_context_bridge.cc
View File

@@ -220,9 +220,9 @@ v8::MaybeLocal<v8::Value> PassValueToOtherContext(
// Make the promise a shared_ptr so that when the original promise is
// freed the proxy promise is correctly freed as well instead of being
// left dangling
std::shared_ptr<gin_helper::Promise<v8::Local<v8::Value>>> proxied_promise(
new gin_helper::Promise<v8::Local<v8::Value>>(
destination_context->GetIsolate()));
auto proxied_promise =
std::make_shared<gin_helper::Promise<v8::Local<v8::Value>>>(
destination_context->GetIsolate());
v8::Local<v8::Promise> proxied_promise_handle =
proxied_promise->GetHandle();