github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: send null in debugger callback when no error (#14814)

Browse Source 
Fixes #13811
This commit is contained in:
Samuel Attard
2018-09-27 17:43:45 +10:00
committed by GitHub
parent 985d35fc1c
commit 7dc7cd1d89
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
spec/api-debugger-spec.js
View File

@@ -111,7 +111,7 @@ describe('debugger module', () => {
}
const callback = (err, res) => {
expect(err.message).to.be.undefined()
expect(err).to.be.null()
expect(res.wasThrown).to.be.undefined()
expect(res.result.value).to.equal(6)
@@ -131,7 +131,7 @@ describe('debugger module', () => {
return done(`unexpected error : ${err}`)
}
const callback = (err, res) => {
expect(err.message).to.be.undefined()
expect(err).to.be.null()
expect(res.wasThrown).to.be.undefined()
expect(res.result.value).to.equal(6)
w.webContents.debugger.detach()
@@ -178,6 +178,7 @@ describe('debugger module', () => {
}
w.webContents.debugger.sendCommand('Test', err => {
expect(err).to.not.be.null()
expect(err.message).to.equal("'Test' wasn't found")
w.webContents.debugger.detach()
done()