github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use v8::String::Empty() when creating empty strings (#46371)

Browse Source 
refactor: use v8::String::Empty() when creating empty strings

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
This commit is contained in:
trop[bot]
2025-03-31 10:39:48 +02:00
committed by GitHub
parent 33df588e8e
commit 7e80e8f610
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
shell/browser/api/electron_api_app.cc
View File

@@ -164,7 +164,7 @@ struct Converter<JumpListItem::Type> {
if (item_val == val)
return gin::ConvertToV8(isolate, name);
return gin::ConvertToV8(isolate, "");
return v8::String::Empty(isolate);
}
private:
@@ -255,7 +255,7 @@ struct Converter<JumpListCategory::Type> {
if (type_val == val)
return gin::ConvertToV8(isolate, name);
return gin::ConvertToV8(isolate, "");
return v8::String::Empty(isolate);
}
private:

2
shell/browser/ui/cocoa/electron_bundle_mover.mm
View File

@@ -30,7 +30,7 @@ struct Converter<electron::BundlerMoverConflictType> {
case electron::BundlerMoverConflictType::kExistsAndRunning:
return gin::StringToV8(isolate, "existsAndRunning");
default:
return gin::StringToV8(isolate, "");
return v8::String::Empty(isolate);
}
}
};