github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unnecessary casting to base::Value (#37591)

Browse Source 
Co-authored-by: Milan Burda <miburda@microsoft.com>
This commit is contained in:
Milan Burda
2023-03-20 15:26:42 +01:00
committed by GitHub
parent 64b39dce14
commit 7ed3c7a359
5 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/ui/inspectable_web_contents.cc
View File

@@ -623,7 +623,7 @@ void InspectableWebContents::AddDevToolsExtensionsToClient() {
extension_info.Set("exposeExperimentalAPIs",
extension->permissions_data()->HasAPIPermission(
extensions::mojom::APIPermissionID::kExperimental));
results.Append(base::Value(std::move(extension_info)));
results.Append(std::move(extension_info));
}
CallClientFunction("DevToolsAPI", "addExtensions",

4
shell/browser/ui/webui/accessibility_ui.cc
View File

@@ -282,7 +282,7 @@ void HandleAccessibilityRequestCallback(
descriptor.Set(kNative, is_native_enabled);
descriptor.Set(kWeb, is_web_enabled);
descriptor.Set(kLabelImages, are_accessibility_image_labels_enabled);
rvh_list.Append(base::Value(std::move(descriptor)));
rvh_list.Append(std::move(descriptor));
}
data.Set(kPagesField, std::move(rvh_list));
@@ -295,7 +295,7 @@ void HandleAccessibilityRequestCallback(
data.Set(kBrowsersField, std::move(window_list));
std::string json_string;
base::JSONWriter::Write(base::Value(std::move(data)), &json_string);
base::JSONWriter::Write(data, &json_string);
std::move(callback).Run(
base::MakeRefCounted<base::RefCountedString>(std::move(json_string)));