github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

perf: use type-utils for desktopCapturer.getSources() result serialization (#23549)

Browse Source
This commit is contained in:
Milan Burda
2020-05-13 19:05:53 +02:00
committed by GitHub
parent 508c7ac4f9
commit 85fae67966
5 changed files with 11 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
shell/browser/api/electron_api_desktop_capturer.cc
View File

@@ -49,6 +49,8 @@ struct Converter<electron::api::DesktopCapturer::Source> {
"appIcon",
electron::api::NativeImage::Create(
isolate, gfx::Image(GetWindowIcon(source.media_list_source.id))));
} else {
dict.Set("appIcon", nullptr);
}
return ConvertToV8(isolate, dict);
}
@@ -191,8 +193,7 @@ void DesktopCapturer::UpdateSourcesList(DesktopMediaList* list) {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
v8::Locker locker(isolate);
v8::HandleScope scope(isolate);
gin_helper::CallMethod(this, "_onfinished", captured_sources_,
fetch_window_icons_);
gin_helper::CallMethod(this, "_onfinished", captured_sources_);
}
}