From 866cbb01478cd77b7f27e96e1f3e03eb2f9929fc Mon Sep 17 00:00:00 2001 From: Samuel Attard Date: Thu, 21 Mar 2019 20:21:36 -0700 Subject: [PATCH] fix: SetCanonicalCookieAsync now takes the full CookieOptions Refs: https://chromium-review.googlesource.com/c/chromium/src/+/1471244 --- atom/browser/api/atom_api_cookies.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/atom/browser/api/atom_api_cookies.cc b/atom/browser/api/atom_api_cookies.cc index 2be84fd1cc..09a33ce203 100644 --- a/atom/browser/api/atom_api_cookies.cc +++ b/atom/browser/api/atom_api_cookies.cc @@ -303,8 +303,12 @@ void SetCookieOnIO(scoped_refptr getter, EXCLUDE_FAILURE_TO_STORE); return; } + net::CookieOptions options; + if (http_only) { + options.set_include_httponly(); + } GetCookieStore(getter)->SetCanonicalCookieAsync( - std::move(canonical_cookie), url.scheme(), http_only, + std::move(canonical_cookie), url.scheme(), options, std::move(completion_callback)); }