github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: declare gin::Wrapper subclasses as final (#43527)

Browse Source 
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
This commit is contained in:
Charles Kerr
2024-09-04 18:40:02 -05:00
committed by GitHub
parent 94f2722fa3
commit 8ae5aacc8c
35 changed files with 106 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shell/browser/api/electron_api_debugger.h
View File

@@ -32,10 +32,10 @@ class Promise;
namespace electron::api {
class Debugger : public gin::Wrappable<Debugger>,
public gin_helper::EventEmitterMixin<Debugger>,
public content::DevToolsAgentHostClient,
private content::WebContentsObserver {
class Debugger final : public gin::Wrappable<Debugger>,
public gin_helper::EventEmitterMixin<Debugger>,
public content::DevToolsAgentHostClient,
private content::WebContentsObserver {
public:
static gin::Handle<Debugger> Create(v8::Isolate* isolate,
content::WebContents* web_contents);