github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-08 23:18:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: declare gin::Wrapper subclasses as final (#43527)

Browse Source 
As per the gin docs: "Wrappable<T> explicitly does not support further
subclassing of T. Subclasses of Wrappable<T> should be declared final."
This commit is contained in:
Charles Kerr
2024-09-04 18:40:02 -05:00
committed by GitHub
parent 94f2722fa3
commit 8ae5aacc8c
35 changed files with 106 additions and 103 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/common/api/electron_api_url_loader.h
View File

@@ -47,7 +47,7 @@ class ElectronBrowserContext;
namespace electron::api {
/** Wraps a SimpleURLLoader to make it usable from JavaScript */
class SimpleURLLoaderWrapper
class SimpleURLLoaderWrapper final
: public gin::Wrappable<SimpleURLLoaderWrapper>,
public gin_helper::EventEmitterMixin<SimpleURLLoaderWrapper>,
private network::SimpleURLLoaderStreamConsumer,