github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

chore: 'breaking change' in PR body overrides commit type in relnotes (#16911)

Browse Source
This commit is contained in:
Jeremy Apthorp
2019-02-12 21:30:39 -08:00
committed by GitHub
parent ca83d36426
commit 8d09219533
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
script/release-notes/notes.js
View File

@@ -521,10 +521,13 @@ const getNotes = async (fromRef, toRef, newVersion) => {
}
// try to pull a release note from the pull comment
const prParsed = {}
parseCommitMessage(`${prData.data.title}\n\n${prData.data.body}`, pr.owner, pr.repo, prParsed)
commit.note = commit.note || prParsed.note
commit.type = commit.type || prParsed.type
const prParsed = parseCommitMessage(`${prData.data.title}\n\n${prData.data.body}`, pr.owner, pr.repo)
if (!commit.note) {
commit.note = prParsed.note
}
if (!commit.type || prParsed.type === 'breaking-change') {
commit.type = prParsed.type
}
prSubject = prSubject || prParsed.subject
pr = prParsed.pr && (prParsed.pr.number !== pr.number) ? prParsed.pr : null