github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #8478 from deepak1556/load_url_max_char_patch

Browse Source 
WebContents: emit did-fail-load event when url exceeds character limit
This commit is contained in:
Kevin Sawicki
2017-01-25 09:46:40 -08:00
committed by GitHub
parent 90470617ab d8a16a8ffb
commit 8e39aea34a
2 changed files with 22 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
spec/api-browser-window-spec.js
View File

@@ -218,6 +218,17 @@ describe('BrowserWindow module', function () {
w.loadURL('http://127.0.0.1:11111')
})
it('should emit did-fail-load event for URL exceeding character limit', function (done) {
w.webContents.on('did-fail-load', function (event, code, desc, url, isMainFrame) {
assert.equal(desc, 'ERR_INVALID_URL')
assert.equal(code, -300)
assert.equal(isMainFrame, true)
done()
})
const data = new Buffer(2 * 1024 * 1024).toString('base64')
w.loadURL(`data:image/png;base64,${data}`)
})
describe('POST navigations', function () {
afterEach(() => {
w.webContents.session.webRequest.onBeforeSendHeaders(null)