github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: crash with creating OffScreenWebContentsView (#42920)

Browse Source 
On the Mac platform, OffScreenWebContentsView uses Automatic Reference
Counting (ARC) to handle the lifecycle of offScreenView_. However, this
private member variable is not initialized and its value is undefined.
In some cases, it is initialized to a garbage value, which may cause ARC
to release the value incorrectly, resulting in a crash.
This commit is contained in:
wujinli
2024-07-17 19:09:32 +08:00
committed by GitHub
parent 2875fab452
commit 9023707b9b
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/browser/osr/osr_web_contents_view.h
View File

@@ -109,7 +109,7 @@ class OffScreenWebContentsView : public content::WebContentsView,
raw_ptr<content::WebContents> web_contents_ = nullptr;
#if BUILDFLAG(IS_MAC)
RAW_PTR_EXCLUSION OffScreenView* offScreenView_;
RAW_PTR_EXCLUSION OffScreenView* offScreenView_ = nullptr;
#endif
};