github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

refactor: make StatusIconType an enum class (#36500)

Browse Source 
Co-authored-by: Milan Burda <miburda@microsoft.com>
This commit is contained in:
Milan Burda
2022-12-05 09:59:20 +01:00
committed by GitHub
parent 79d2fc9c23
commit 909ee0ed6b
2 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
shell/browser/ui/tray_icon_gtk.cc
View File

@@ -30,7 +30,8 @@ gfx::ImageSkia GetBestImageRep(const gfx::ImageSkia& image) {
} // namespace
TrayIconGtk::TrayIconGtk()
: status_icon_(new StatusIconLinuxDbus), status_icon_type_(kTypeDbus) {
: status_icon_(new StatusIconLinuxDbus),
status_icon_type_(StatusIconType::kDbus) {
status_icon_->SetDelegate(this);
}
@@ -68,11 +69,11 @@ ui::MenuModel* TrayIconGtk::GetMenuModel() const {
void TrayIconGtk::OnImplInitializationFailed() {
switch (status_icon_type_) {
case kTypeDbus:
case StatusIconType::kDbus:
status_icon_ = nullptr;
status_icon_type_ = kTypeNone;
status_icon_type_ = StatusIconType::kNone;
return;
case kTypeNone:
case StatusIconType::kNone:
NOTREACHED();
}
}

6
shell/browser/ui/tray_icon_gtk.h
View File

@@ -36,9 +36,9 @@ class TrayIconGtk : public TrayIcon, public ui::StatusIconLinux::Delegate {
void OnImplInitializationFailed() override;
private:
enum StatusIconType {
kTypeDbus,
kTypeNone,
enum class StatusIconType {
kDbus,
kNone,
};
scoped_refptr<StatusIconLinuxDbus> status_icon_;