diff --git a/.github/workflows/electron_woa_testing.yml b/.github/workflows/electron_woa_testing.yml deleted file mode 100644 index 3af8d005f3..0000000000 --- a/.github/workflows/electron_woa_testing.yml +++ /dev/null @@ -1,166 +0,0 @@ -name: Electron WOA Testing - -on: - push: - branches: '**' - workflow_dispatch: - inputs: - appveyor_job_id: - description: 'Job Id of Appveyor WOA job to test' - type: text - required: true - -permissions: # added using https://github.com/step-security/secure-workflows - contents: read - -jobs: - electron-woa-init: - if: ${{ github.event_name == 'push' && github.repository == 'electron/electron' }} - runs-on: ubuntu-latest - steps: - - name: Dummy step for push event - run: | - echo "This job is a needed initialization step for Electron WOA testing. Another test result will appear once the electron-woa-testing build is done." - - electron-woa-testing: - if: ${{ github.event_name == 'workflow_dispatch' && github.repository == 'electron/electron' }} - runs-on: [self-hosted, woa] - permissions: - checks: write - pull-requests: write - steps: - - uses: LouisBrunner/checks-action@442ad2296fb110373e3fe01c2a3717b546583631 # tag: v1.1.1 - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: electron-woa-testing - status: in_progress - details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - output: | - {"summary":"Test In Progress","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"} - - name: Clean Workspace - run: | - Remove-Item * -Recurse -Force - shell: powershell - - name: Checkout - uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 # tag: v3 - with: - path: src\electron - fetch-depth: 0 - - name: Yarn install - run: | - cd src\electron - node script/yarn.js install --frozen-lockfile - - name: Download and extract dist.zip for test - run: | - $localArtifactPath = "$pwd\dist.zip" - $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/dist.zip" - Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" } - & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -osrc\out\Default -y $localArtifactPath - shell: powershell - - name: Download and extract native test executables for test - run: | - $localArtifactPath = "src\out\Default\shell_browser_ui_unittests.exe" - $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/shell_browser_ui_unittests.exe" - Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" } - shell: powershell - - name: Download and extract ffmpeg.zip for test - run: | - $localArtifactPath = "$pwd\ffmpeg.zip" - $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/ffmpeg.zip" - Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" } - & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -osrc\out\ffmpeg $localArtifactPath - shell: powershell - - name: Download node headers for test - run: | - $localArtifactPath = "src\node_headers.zip" - $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/node_headers.zip" - Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" } - cd src - & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -y node_headers.zip - shell: powershell - - name: Download electron.lib for test - run: | - $localArtifactPath = "src\out\Default\electron.lib" - $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/electron.lib" - Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" } - shell: powershell - # Uncomment the following block if pdb files are needed to debug issues - # - name: Download pdb files for detailed stacktraces - # if: ${{ github.event_name == 'workflow_dispatch' }} - # run: | - # try { - # $localArtifactPath = "src\pdb.zip" - # $serverArtifactPath = "https://ci.appveyor.com/api/buildjobs/${{ inputs.appveyor_job_id }}/artifacts/pdb.zip" - # Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer ${{ secrets.APPVEYOR_TOKEN }}" } - # cd src - # & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -y pdb.zip - # } catch { - # Write-Host "There was an exception encountered while downloading pdb files:" $_.Exception.Message - # } finally { - # $global:LASTEXITCODE = 0 - # } - # shell: powershell - - name: Setup node headers - run: | - New-Item src\out\Default\gen\node_headers\Release -Type directory - Copy-Item -path src\out\Default\electron.lib -destination src\out\Default\gen\node_headers\Release\node.lib - shell: powershell - - name: Run Electron Main process tests - run: | - cd src - set npm_config_nodedir=%cd%\out\Default\gen\node_headers - set npm_config_arch=arm64 - cd electron - node script/yarn test --runners=main --enable-logging --disable-features=CalculateNativeWinOcclusion - env: - ELECTRON_ENABLE_STACK_DUMPING: true - ELECTRON_OUT_DIR: Default - IGNORE_YARN_INSTALL_ERROR: 1 - ELECTRON_TEST_RESULTS_DIR: junit - MOCHA_MULTI_REPORTERS: 'mocha-junit-reporter, tap' - MOCHA_REPORTER: mocha-multi-reporters - ELECTRON_SKIP_NATIVE_MODULE_TESTS: true - - name: Verify ffmpeg - run: | - cd src - echo "Verifying non proprietary ffmpeg" - python electron\script\verify-ffmpeg.py --build-dir out\Default --source-root %cd% --ffmpeg-path out\ffmpeg - shell: cmd - - name: Kill processes left running from last test run - if: ${{ always() }} - run: | - Get-Process | Where Name -Like "electron*" | Stop-Process - Get-Process | Where Name -Like "msedge*" | Stop-Process - shell: powershell - - name: Delete user app data directories - if: ${{ always() }} - run: | - Remove-Item -path $env:APPDATA/Electron* -Recurse -Force -ErrorAction Ignore - shell: powershell - - uses: LouisBrunner/checks-action@442ad2296fb110373e3fe01c2a3717b546583631 # tag: v1.1.1 - if: ${{ success() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: electron-woa-testing - conclusion: "${{ job.status }}" - details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - output: | - {"summary":"${{ job.status }}","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"} - - uses: LouisBrunner/checks-action@442ad2296fb110373e3fe01c2a3717b546583631 # tag: v1.1.1 - if: ${{ success() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: electron-woa-testing - conclusion: "${{ job.status }}" - details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - output: | - {"summary":"Job Succeeded","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"} - - uses: LouisBrunner/checks-action@442ad2296fb110373e3fe01c2a3717b546583631 # tag: v1.1.1 - if: ${{ ! success() }} - with: - token: ${{ secrets.GITHUB_TOKEN }} - name: electron-woa-testing - conclusion: "${{ job.status }}" - details_url: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }} - output: | - {"summary":"Job Failed","text_description":"See job details here: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"} diff --git a/appveyor-woa.yml b/appveyor-woa.yml new file mode 100644 index 0000000000..5ba8c4c686 --- /dev/null +++ b/appveyor-woa.yml @@ -0,0 +1,276 @@ +# NOTE IF CHANGING THIS FILE, ALSO APPLY THE CHANGE TO appveyor.yml +# IF APPLICABLE!!!! +# +# +# The config expects the following environment variables to be set: +# - "GN_CONFIG" Build type. One of {'testing', 'release'}. +# - "GN_EXTRA_ARGS" Additional gn arguments for a build config, +# e.g. 'target_cpu="x86"' to build for a 32bit platform. +# https://gn.googlesource.com/gn/+/master/docs/reference.md#target_cpu +# Don't forget to set up "NPM_CONFIG_ARCH" and "TARGET_ARCH" accordingly +# if you pass a custom value for 'target_cpu'. +# - "ELECTRON_RELEASE" Set it to '1' upload binaries on success. +# - "NPM_CONFIG_ARCH" E.g. 'x86'. Is used to build native Node.js modules. +# Must match 'target_cpu' passed to "GN_EXTRA_ARGS" and "TARGET_ARCH" value. +# - "TARGET_ARCH" Choose from {'ia32', 'x64', 'arm', 'arm64', 'mips64el'}. +# Is used in some publishing scripts, but does NOT affect the Electron binary. +# Must match 'target_cpu' passed to "GN_EXTRA_ARGS" and "NPM_CONFIG_ARCH" value. +# - "UPLOAD_TO_STORAGE" Set it to '1' upload a release to the Azure bucket. +# Otherwise the release will be uploaded to the GitHub Releases. +# (The value is only checked if "ELECTRON_RELEASE" is defined.) +# +# The publishing scripts expect access tokens to be defined as env vars, +# but those are not covered here. +# +# AppVeyor docs on variables: +# https://www.appveyor.com/docs/environment-variables/ +# https://www.appveyor.com/docs/build-configuration/#secure-variables +# https://www.appveyor.com/docs/build-configuration/#custom-environment-variables + +version: 1.0.{build} +build_cloud: electronhq-16-core +image: e-111.0.5518.0 +environment: + GIT_CACHE_PATH: C:\Users\appveyor\libcc_cache + ELECTRON_OUT_DIR: Default + ELECTRON_ENABLE_STACK_DUMPING: 1 + ELECTRON_ALSO_LOG_TO_STDERR: 1 + MOCHA_REPORTER: mocha-multi-reporters + MOCHA_MULTI_REPORTERS: mocha-appveyor-reporter, tap + GOMA_FALLBACK_ON_AUTH_FAILURE: true + DEPOT_TOOLS_WIN_TOOLCHAIN: 0 + PYTHONIOENCODING: UTF-8 + + matrix: + + - job_name: Build Arm on X64 Windows + - job_name: Test On Windows On Arm Hardware + job_depends_on: Build Arm on X64 Windows + APPVEYOR_BUILD_WORKER_IMAGE: base-woa + APPVEYOR_BUILD_WORKER_CLOUD: electronhq-woa + +clone_folder: C:\projects\src\electron + +# the first failed job cancels other jobs and fails entire build +matrix: + fast_finish: true + +for: + + - matrix: + only: + - job_name: Build Arm on X64 Windows + + build_script: + - ps: | + node script/yarn.js install --frozen-lockfile + node script/doc-only-change.js --prNumber=$env:APPVEYOR_PULL_REQUEST_NUMBER --prBranch=$env:APPVEYOR_REPO_BRANCH + if ($LASTEXITCODE -eq 0) { + Write-warning "Skipping build for doc only change"; Exit-AppveyorBuild + } + $global:LASTEXITCODE = 0 + - cd .. + - ps: Write-Host "Building $env:GN_CONFIG build" + - git config --global core.longpaths true + - ps: >- + if (Test-Path -Path "$pwd\depot_tools") { + Remove-Item -Recurse -Force $pwd\depot_tools + } + - ps: >- + if (Test-Path -Path "$pwd\build-tools") { + Remove-Item -Recurse -Force $pwd\build-tools + } + - ps: git clone --depth=1 https://chromium.googlesource.com/chromium/tools/depot_tools.git + - ps: $env:PATH="$pwd\depot_tools;$env:PATH" + - ps: >- + if (Test-Path -Path "$pwd\src\electron") { + Remove-Item -Recurse -Force $pwd\src\electron + } + - ps: >- + if (Test-Path 'env:RAW_GOMA_AUTH') { + $env:GOMA_OAUTH2_CONFIG_FILE = "$pwd\.goma_oauth2_config" + $env:RAW_GOMA_AUTH | Set-Content $env:GOMA_OAUTH2_CONFIG_FILE + } + - git clone https://github.com/electron/build-tools.git + - cd build-tools + - npm install + - mkdir third_party + - ps: >- + node -e "require('./src/utils/goma.js').downloadAndPrepare({ gomaOneForAll: true })" + - ps: $env:GN_GOMA_FILE = node -e "console.log(require('./src/utils/goma.js').gnFilePath)" + - ps: $env:LOCAL_GOMA_DIR = node -e "console.log(require('./src/utils/goma.js').dir)" + - cd ..\.. + - ps: .\src\electron\script\start-goma.ps1 -gomaDir $env:LOCAL_GOMA_DIR + - ps: >- + if (Test-Path 'env:RAW_GOMA_AUTH') { + $goma_login = python $env:LOCAL_GOMA_DIR\goma_auth.py info + if ($goma_login -eq 'Login as Fermi Planck') { + Write-warning "Goma authentication is correct"; + } else { + Write-warning "WARNING!!!!!! Goma authentication is incorrect; please update Goma auth token."; + $host.SetShouldExit(1) + } + } + - ps: $env:CHROMIUM_BUILDTOOLS_PATH="$pwd\src\buildtools" + - ps: >- + if ($env:GN_CONFIG -ne 'release') { + $env:NINJA_STATUS="[%r processes, %f/%t @ %o/s : %es] " + } + - gclient config --name "src\electron" --unmanaged %GCLIENT_EXTRA_ARGS% "https://github.com/electron/electron" + # Patches are applied in the image bake. Check depshash to see if patches have changed. + - ps: $env:RUN_GCLIENT_SYNC="false" + - ps: $depshash_baked = Get-Content .\src\.depshash -Raw + - ps: cd src\electron + - ps: node script\generate-deps-hash.js + - ps: $depshash = Get-Content .\.depshash -Raw + - ps: cd ..\.. + - ps: >- + if ($depshash_baked -ne $depshash) { + $env:RUN_GCLIENT_SYNC="true" + } + - if "%RUN_GCLIENT_SYNC%"=="true" ( gclient sync --with_branch_heads --with_tags ) else ( gclient runhooks ) + - cd src + - set BUILD_CONFIG_PATH=//electron/build/args/%GN_CONFIG%.gn + - gn gen out/Default "--args=import(\"%BUILD_CONFIG_PATH%\") import(\"%GN_GOMA_FILE%\") %GN_EXTRA_ARGS% " + - gn check out/Default //electron:electron_lib + - gn check out/Default //electron:electron_app + - gn check out/Default //electron/shell/common/api:mojo + - if DEFINED GN_GOMA_FILE (ninja -j 300 -C out/Default electron:electron_app) else (ninja -C out/Default electron:electron_app) + - if "%GN_CONFIG%"=="testing" ( python C:\depot_tools\post_build_ninja_summary.py -C out\Default ) + - gn gen out/ffmpeg "--args=import(\"//electron/build/args/ffmpeg.gn\") %GN_EXTRA_ARGS%" + - ninja -C out/ffmpeg electron:electron_ffmpeg_zip + - ninja -C out/Default electron:electron_dist_zip + - ninja -C out/Default shell_browser_ui_unittests + - gn desc out/Default v8:run_mksnapshot_default args > out/Default/default_mksnapshot_args + # Remove unused args from mksnapshot_args + - ps: >- + Get-Content out/Default/default_mksnapshot_args | Where-Object { -not $_.Contains('--turbo-profiling-input') -And -not $_.Contains('builtins-pgo') } | Set-Content out/Default/mksnapshot_args + - ninja -C out/Default electron:electron_mksnapshot_zip + - cd out\Default + - 7z a mksnapshot.zip mksnapshot_args gen\v8\embedded.S + - cd ..\.. + - ninja -C out/Default electron:hunspell_dictionaries_zip + - ninja -C out/Default electron:electron_chromedriver_zip + - ninja -C out/Default third_party/electron_node:headers + - python %LOCAL_GOMA_DIR%\goma_ctl.py stat + - ps: >- + Get-CimInstance -Namespace root\cimv2 -Class Win32_product | Select vendor, description, @{l='install_location';e='InstallLocation'}, @{l='install_date';e='InstallDate'}, @{l='install_date_2';e='InstallDate2'}, caption, version, name, @{l='sku_number';e='SKUNumber'} | ConvertTo-Json | Out-File -Encoding utf8 -FilePath .\installed_software.json + - python3 electron/build/profile_toolchain.py --output-json=out/Default/windows_toolchain_profile.json + - 7z a node_headers.zip out\Default\gen\node_headers + - ps: >- + if ($env:GN_CONFIG -eq 'release') { + # Needed for msdia140.dll on 64-bit windows + $env:Path += ";$pwd\third_party\llvm-build\Release+Asserts\bin" + ninja -C out/Default electron:electron_symbols + } + - ps: >- + if ($env:GN_CONFIG -eq 'release') { + python3 electron\script\zip-symbols.py + appveyor-retry appveyor PushArtifact out/Default/symbols.zip + } else { + # It's useful to have pdb files when debugging testing builds that are + # built on CI. + 7z a pdb.zip out\Default\*.pdb + } + - python3 electron/script/zip_manifests/check-zip-manifest.py out/Default/dist.zip electron/script/zip_manifests/dist_zip.win.%TARGET_ARCH%.manifest + + deploy_script: + - cd electron + - ps: >- + if (Test-Path Env:\ELECTRON_RELEASE) { + if (Test-Path Env:\UPLOAD_TO_STORAGE) { + Write-Output "Uploading Electron release distribution to azure" + & python3 script\release\uploaders\upload.py --verbose --upload_to_storage + } else { + Write-Output "Uploading Electron release distribution to github releases" + & python3 script\release\uploaders\upload.py --verbose + } + } + on_finish: + # Uncomment this lines to enable RDP + # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1')) + - cd C:\projects\src + - if exist out\Default\windows_toolchain_profile.json ( appveyor-retry appveyor PushArtifact out\Default\windows_toolchain_profile.json ) + - if exist out\Default\dist.zip (appveyor-retry appveyor PushArtifact out\Default\dist.zip) + - if exist out\Default\shell_browser_ui_unittests.exe (appveyor-retry appveyor PushArtifact out\Default\shell_browser_ui_unittests.exe) + - if exist out\Default\chromedriver.zip (appveyor-retry appveyor PushArtifact out\Default\chromedriver.zip) + - if exist out\ffmpeg\ffmpeg.zip (appveyor-retry appveyor PushArtifact out\ffmpeg\ffmpeg.zip) + - if exist node_headers.zip (appveyor-retry appveyor PushArtifact node_headers.zip) + - if exist out\Default\mksnapshot.zip (appveyor-retry appveyor PushArtifact out\Default\mksnapshot.zip) + - if exist out\Default\hunspell_dictionaries.zip (appveyor-retry appveyor PushArtifact out\Default\hunspell_dictionaries.zip) + - if exist out\Default\electron.lib (appveyor-retry appveyor PushArtifact out\Default\electron.lib) + - ps: >- + if ((Test-Path "pdb.zip") -And ($env:GN_CONFIG -ne 'release')) { + appveyor-retry appveyor PushArtifact pdb.zip + } + - matrix: + only: + - job_name: Test On Windows On Arm Hardware + + environment: + IGNORE_YARN_INSTALL_ERROR: 1 + ELECTRON_TEST_RESULTS_DIR: junit + MOCHA_MULTI_REPORTERS: 'mocha-junit-reporter, tap' + MOCHA_REPORTER: mocha-multi-reporters + ELECTRON_SKIP_NATIVE_MODULE_TESTS: true + + build_script: + - ps: | + node script/yarn.js install --frozen-lockfile + node script/doc-only-change.js --prNumber=$env:APPVEYOR_PULL_REQUEST_NUMBER --prBranch=$env:APPVEYOR_REPO_BRANCH + if ($LASTEXITCODE -eq 0) { + Write-warning "Skipping build for doc only change"; Exit-AppveyorBuild + } + $global:LASTEXITCODE = 0 + - cd .. + - mkdir out\Default + - cd .. + - ps: | + # Download build artifacts + $apiUrl = 'https://ci.appveyor.com/api' + $build_info = Invoke-RestMethod -Method Get -Uri "$apiUrl/projects/$env:APPVEYOR_ACCOUNT_NAME/$env:APPVEYOR_PROJECT_SLUG/builds/$env:APPVEYOR_BUILD_ID" + $artifacts_to_download = @('dist.zip','ffmpeg.zip','node_headers.zip','pdb.zip','electron.lib') + foreach ($job in $build_info.build.jobs) { + if ($job.name -eq "Build Arm on X64 Windows") { + $jobId = $job.jobId + foreach($artifact_name in $artifacts_to_download) { + if ($artifact_name -eq 'shell_browser_ui_unittests.exe' -Or $artifact_name -eq 'electron.lib') { + $outfile = "src\out\Default\$artifact_name" + } else { + $outfile = $artifact_name + } + Invoke-RestMethod -Method Get -Uri "$apiUrl/buildjobs/$jobId/artifacts/$artifact_name" -OutFile $outfile + } + } + } + - ps: | + $out_default_zips = @('dist.zip','pdb.zip') + foreach($zip_name in $out_default_zips) { + 7z x -y -osrc\out\Default $zip_name + } + - ps: 7z x -y -osrc\out\ffmpeg ffmpeg.zip + - ps: 7z x -y -osrc node_headers.zip + + test_script: + # Workaround for https://github.com/appveyor/ci/issues/2420 + - set "PATH=%PATH%;C:\Program Files\Git\mingw64\libexec\git-core" + - ps: | + cd src + New-Item .\out\Default\gen\node_headers\Release -Type directory + Copy-Item -path .\out\Default\electron.lib -destination .\out\Default\gen\node_headers\Release\node.lib + - set npm_config_nodedir=%cd%\out\Default\gen\node_headers + - set npm_config_arch=arm64 + - cd electron + # Explicitly set npm_config_arch because the .env doesn't persist + - ps: >- + if ($env:TARGET_ARCH -eq 'ia32') { + $env:npm_config_arch = "ia32" + } + - echo Running main test suite & node script/yarn test --runners=main --enable-logging --disable-features=CalculateNativeWinOcclusion + - cd .. + - echo Verifying non proprietary ffmpeg & python electron\script\verify-ffmpeg.py --build-dir out\Default --source-root %cd% --ffmpeg-path out\ffmpeg + + on_finish: + # Uncomment these lines to enable RDP + # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1')) + - if exist electron\electron.log ( appveyor-retry appveyor PushArtifact electron\electron.log ) \ No newline at end of file diff --git a/appveyor.yml b/appveyor.yml index ba245cd39c..33035278f9 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,3 +1,7 @@ +# NOTE IF CHANGING THIS FILE, ALSO APPLY THE CHANGE TO appveyor-woa.yml +# IF APPLICABLE!!!! +# +# # The config expects the following environment variables to be set: # - "GN_CONFIG" Build type. One of {'testing', 'release'}. # - "GN_EXTRA_ARGS" Additional gn arguments for a build config, @@ -55,12 +59,6 @@ for: only: - job_name: Build - init: - - ps: >- - if(($env:APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME -split "/")[0] -eq ($env:APPVEYOR_REPO_NAME -split "/")[0]) { - Write-warning "Skipping PR build for branch"; Exit-AppveyorBuild - } - build_script: - ps: | node script/yarn.js install --frozen-lockfile @@ -185,8 +183,6 @@ for: Write-Output "Uploading Electron release distribution to github releases" & python3 script\release\uploaders\upload.py --verbose } - } elseif (Test-Path Env:\TEST_WOA) { - node script/release/ci-release-build.js --job=electron-woa-testing --ci=GHA --appveyorJobId=$env:APPVEYOR_JOB_ID $env:APPVEYOR_REPO_BRANCH } on_finish: # Uncomment this lines to enable RDP @@ -214,9 +210,6 @@ for: if ($env:RUN_TESTS -ne 'true') { Write-warning "Skipping tests for $env:APPVEYOR_PROJECT_NAME"; Exit-AppveyorBuild } - if(($env:APPVEYOR_PULL_REQUEST_HEAD_REPO_NAME -split "/")[0] -eq ($env:APPVEYOR_REPO_NAME -split "/")[0]) { - Write-warning "Skipping PR build for branch"; Exit-AppveyorBuild - } build_script: - ps: | node script/yarn.js install --frozen-lockfile @@ -276,8 +269,8 @@ for: - echo "Done verifying mksnapshot" - echo Verifying chromedriver & python electron\script\verify-chromedriver.py --build-dir out\Default --source-root %cd% - echo "Done verifying chromedriver" - - # Uncomment these lines to enable RDP - # on_finish: + + on_finish: + # Uncomment these lines to enable RDP # - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1')) - if exist electron\electron.log ( appveyor-retry appveyor PushArtifact electron\electron.log ) \ No newline at end of file diff --git a/script/release/ci-release-build.js b/script/release/ci-release-build.js index 1121f7b561..e79dfc9627 100644 --- a/script/release/ci-release-build.js +++ b/script/release/ci-release-build.js @@ -24,8 +24,6 @@ const circleCIPublishIndividualArches = { 'linux-publish': ['arm', 'arm64', 'x64'] }; -const GHAJobs = ['electron-woa-testing']; - let jobRequestedCount = 0; async function makeRequest ({ auth, username, password, url, headers, body, method }) { @@ -250,31 +248,6 @@ function buildCircleCI (targetBranch, options) { } } -async function buildGHA (targetBranch, options) { - const { GHA_TOKEN } = process.env; - assert(GHA_TOKEN, `${options.ci} requires the $GHA_TOKEN environment variable to be provided`); - - const octokit = new Octokit({ auth: GHA_TOKEN }); - - assert(GHAJobs.includes(options.job), `Unknown GitHub Actions arm test job name: ${options.job}. Valid values are: ${GHAJobs}.`); - assert(options.commit !== null, 'commit is a required option for GitHub Actions'); - - console.log(`Triggering GitHub Actions to run build on branch: ${targetBranch}.`); - - jobRequestedCount++; - - try { - const response = await octokit.request('POST /repos/electron/electron/actions/workflows/electron_woa_testing.yml/dispatches', { - ref: targetBranch, - inputs: { - appveyor_job_id: `${options.appveyorJobId}` - } - }); - } catch (err) { - console.log('Problem calling GitHub Actions to get build definitions: ', err); - } -} - function runRelease (targetBranch, options) { if (options.ci) { switch (options.ci) { @@ -286,10 +259,6 @@ function runRelease (targetBranch, options) { buildAppVeyor(targetBranch, options); break; } - case 'GHA': { - buildGHA(targetBranch, options); - break; - } default: { console.log(`Error! Unknown CI: ${options.ci}.`); process.exit(1); @@ -311,7 +280,7 @@ if (require.main === module) { const targetBranch = args._[0]; if (args._.length < 1) { console.log(`Trigger CI to build release builds of electron. - Usage: ci-release-build.js [--job=CI_JOB_NAME] [--arch=INDIVIDUAL_ARCH] [--ci=CircleCI|AppVeyor|GHA] + Usage: ci-release-build.js [--job=CI_JOB_NAME] [--arch=INDIVIDUAL_ARCH] [--ci=CircleCI|AppVeyor] [--ghRelease] [--circleBuildNum=xxx] [--appveyorJobId=xxx] [--commit=sha] TARGET_BRANCH `); process.exit(0);