From 92ef86b64a48b7caff011d5cb240e5a766347429 Mon Sep 17 00:00:00 2001 From: "trop[bot]" <37223003+trop[bot]@users.noreply.github.com> Date: Fri, 6 Feb 2026 14:28:19 -0800 Subject: [PATCH] refactor: don't log error just for unsigned code (#49675) Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com> Co-authored-by: Noah Gregory --- shell/common/mac/codesign_util.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/shell/common/mac/codesign_util.cc b/shell/common/mac/codesign_util.cc index 3ad25421e6..d40275d897 100644 --- a/shell/common/mac/codesign_util.cc +++ b/shell/common/mac/codesign_util.cc @@ -106,7 +106,10 @@ bool ProcessSignatureIsSameWithCurrentApp(pid_t pid) { status = SecCodeCheckValidity(process_code.get(), kSecCSDefaultFlags, self_requirement.get()); if (status != errSecSuccess && status != errSecCSReqFailed) { - OSSTATUS_LOG(ERROR, status) << "SecCodeCheckValidity"; + // If the code is unsigned, don't log that (it's not an actual error). + if (status != errSecCSUnsigned) { + OSSTATUS_LOG(ERROR, status) << "SecCodeCheckValidity"; + } return false; } return status == errSecSuccess;