github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: isolate callbacks in node_bindings (#23261)

Browse Source 
* fix: isolate callbacks in node_bindings

* clarify microtask policy comment
This commit is contained in:
shelley vohr
2020-04-27 01:03:40 -07:00
committed by GitHub
parent e5fe81ac15
commit 979c291847
2 changed files with 41 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
shell/app/node_main.cc
View File

@@ -164,7 +164,7 @@ int NodeMain(int argc, char* argv[]) {
exec_argc, exec_argv);
CHECK_NE(nullptr, env);
// TODO(codebytere): we shouldn't have to call this - upstream?
// This needs to be called before the inspector is initialized.
env->InitializeDiagnostics();
// This is needed in order to enable v8 host weakref hooks.