From 996ddba7159e0ea13ae48e5d2f6135ce55f0fd02 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 17 Nov 2016 12:23:00 -0800 Subject: [PATCH] Add rpc error for ELECTRON_BROWSER_MEMBER_GET --- lib/browser/rpc-server.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/browser/rpc-server.js b/lib/browser/rpc-server.js index 54868b21d7..e525464155 100644 --- a/lib/browser/rpc-server.js +++ b/lib/browser/rpc-server.js @@ -363,6 +363,11 @@ ipcMain.on('ELECTRON_BROWSER_MEMBER_SET', function (event, id, name, value) { ipcMain.on('ELECTRON_BROWSER_MEMBER_GET', function (event, id, name) { try { let obj = objectsRegistry.get(id) + + if (obj == null) { + throwRPCError(`Cannot get property '${name}' on missing remote object ${id}`) + } + event.returnValue = valueToMeta(event.sender, obj[name]) } catch (error) { event.returnValue = exceptionToMeta(error)