github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: will-attach-webview handler modifying params.instanceId does not break <webview> (#32386)

Browse Source
This commit is contained in:
Milan Burda
2022-01-12 08:41:20 +01:00
committed by GitHub
parent cbe68bdbb8
commit 99ee1fc0eb
5 changed files with 34 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/renderer/web-view/web-view-impl.ts
View File

@@ -25,7 +25,6 @@ export class WebViewImpl {
public hasFocus = false
public internalInstanceId?: number;
public resizeObserver?: ResizeObserver;
public userAgentOverride?: string;
public viewInstanceId: number
// on* Event handlers.
@@ -180,8 +179,7 @@ export class WebViewImpl {
buildParams () {
const params: Record<string, any> = {
instanceId: this.viewInstanceId,
userAgentOverride: this.userAgentOverride
instanceId: this.viewInstanceId
};
for (const [attributeName, attribute] of this.attributes) {