github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-08 23:18:06 -05:00
Code Issues Packages Projects Releases Wiki Activity

refactor: use kKeyModifiers in IsAltModifier() (#47066)

Browse Source 
We probably didn't use this before because IsAltModifier() was written
two years before the KeyModifiers mask was added upstream in 98ec378a.
This commit is contained in:
Charles Kerr
2025-05-14 10:00:00 -05:00
committed by GitHub
parent 6170a5af40
commit 9a7b73b533
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
shell/browser/ui/views/root_view.cc
View File

@@ -20,13 +20,8 @@ bool IsAltKey(const input::NativeWebKeyboardEvent& event) {
}
bool IsAltModifier(const input::NativeWebKeyboardEvent& event) {
using Modifiers = input::NativeWebKeyboardEvent::Modifiers;
int modifiers = event.GetModifiers();
modifiers &= ~Modifiers::kNumLockOn;
modifiers &= ~Modifiers::kCapsLockOn;
return (modifiers == Modifiers::kAltKey) ||
(modifiers == (Modifiers::kAltKey | Modifiers::kIsLeft)) ||
(modifiers == (Modifiers::kAltKey | Modifiers::kIsRight));
using Mods = input::NativeWebKeyboardEvent::Modifiers;
return (event.GetModifiers() & Mods::kKeyModifiers) == Mods::kAltKey;
}
} // namespace