github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7169 from deepak1556/download_defaultname_patch

Browse Source 
browser: provide a default filename when unable to generate from download data
This commit is contained in:
Cheng Zhao
2016-09-16 21:19:21 +09:00
committed by GitHub
parent ea244a5188 e7f1265b64
commit 9dad9478fa
6 changed files with 25 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
atom/browser/api/atom_api_download_item.cc
View File

@@ -135,7 +135,7 @@ std::string DownloadItem::GetFilename() const {
std::string(),
download_item_->GetSuggestedFilename(),
GetMimeType(),
std::string()).LossyDisplayName());
"download").LossyDisplayName());
}
std::string DownloadItem::GetContentDisposition() const {

1
atom/browser/api/atom_api_web_contents.cc
View File

@@ -134,6 +134,7 @@ struct Converter<WindowOpenDisposition> {
case NEW_FOREGROUND_TAB: disposition = "foreground-tab"; break;
case NEW_BACKGROUND_TAB: disposition = "background-tab"; break;
case NEW_POPUP: case NEW_WINDOW: disposition = "new-window"; break;
case SAVE_TO_DISK: disposition = "save-to-disk"; break;
default: break;
}
return mate::ConvertToV8(isolate, disposition);

2
atom/browser/atom_download_manager_delegate.cc
View File

@@ -60,7 +60,7 @@ void AtomDownloadManagerDelegate::CreateDownloadPath(
std::string(),
suggested_filename,
mime_type,
std::string());
"download");
if (!base::PathExists(default_download_path))
base::CreateDirectory(default_download_path);