From 9db2290bcddd5a6e1c1f40000e0272be49bd1a10 Mon Sep 17 00:00:00 2001 From: Keeley Hammond Date: Fri, 6 Feb 2026 07:48:37 -0800 Subject: [PATCH] fix: restore macos 12 support in Node 24 (#49697) --- patches/node/.patches | 1 + ...tore_macos_deployment_target_to_12_0.patch | 24 +++++++++++++++++++ 2 files changed, 25 insertions(+) create mode 100644 patches/node/build_restore_macos_deployment_target_to_12_0.patch diff --git a/patches/node/.patches b/patches/node/.patches index 03db9c8c3d..0bc1e46fc2 100644 --- a/patches/node/.patches +++ b/patches/node/.patches @@ -46,3 +46,4 @@ test_make_buffer_sizes_32bit-aware_in.patch src_refactor_module_wrap_cc_to_update_fixedarray_get_params.patch src_refactor_wasmstreaming_finish_to_accept_a_callback.patch src_stop_using_v8_propertycallbackinfo_t_this.patch +build_restore_macos_deployment_target_to_12_0.patch diff --git a/patches/node/build_restore_macos_deployment_target_to_12_0.patch b/patches/node/build_restore_macos_deployment_target_to_12_0.patch new file mode 100644 index 0000000000..4cfa72e7f8 --- /dev/null +++ b/patches/node/build_restore_macos_deployment_target_to_12_0.patch @@ -0,0 +1,24 @@ +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 +From: Keeley Hammond +Date: Thu, 5 Feb 2026 15:29:44 -0800 +Subject: build: restore macos deployment target to 12.0 + +Partially reverts https://github.com/nodejs/node/commit/8b4022177750530d2c142a5a0349d98fb82f16e2 +Electron will follow Chromium's lead and deprecate macos 12 with +M151, and so we should allow for building until then. + +This patch can be removed at the M151 branch point. + +diff --git a/common.gypi b/common.gypi +index bdadbdaa607b2f668749fc484271de8d126bbd17..8df2802191b7fe6ae14edbd85cb3a5d16eb5a76a 100644 +--- a/common.gypi ++++ b/common.gypi +@@ -677,7 +677,7 @@ + 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings + 'GCC_STRICT_ALIASING': 'NO', # -fno-strict-aliasing + 'PREBINDING': 'NO', # No -Wl,-prebind +- 'MACOSX_DEPLOYMENT_TARGET': '13.5', # -mmacosx-version-min=13.5 ++ 'MACOSX_DEPLOYMENT_TARGET': '12.0', # -mmacosx-version-min=12.0 + 'USE_HEADERMAP': 'NO', + 'WARNING_CFLAGS': [ + '-Wall',