github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

build: use async remove method to handle errors better (#16917)

Browse Source 
On windows removeSync randomly seems to fail with DIRNOTEMPTY. By using
the async version fs-extra will do some back-off-retry logic to
hopefully get this dir deleted
This commit is contained in:
Samuel Attard
2019-03-25 18:34:03 -07:00
committed by Cheng Zhao
parent cbd884060e
commit 9e26dfaa06
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
script/gn-asar.js
View File

@@ -46,14 +46,18 @@ try {
}
} catch (err) {
console.error('Unexpected error while generating ASAR', err)
fs.removeSync(tmpPath)
process.exit(1)
fs.remove(tmpPath)
.then(() => process.exit(1))
.catch(() => process.exit(1))
return
}
// Create the ASAR archive
asar.createPackageWithOptions(tmpPath, out[0], {})
.catch(err => {
fs.removeSync(tmpPath)
console.error('Unexpected error while generating ASAR', err)
process.exit(1)
const exit = () => {
console.error('Unexpected error while generating ASAR', err)
process.exit(1)
}
fs.remove(tmpPath).then(exit).catch(exit)
}).then(() => fs.remove(tmpPath))