From 9e8ee3c899970b2f73000ea0e045cc83bcd6e315 Mon Sep 17 00:00:00 2001 From: Jeremy Apthorp Date: Thu, 9 Apr 2020 16:40:58 -0700 Subject: [PATCH] fix: reset node env earlier during shutdown (#23039) --- shell/browser/electron_browser_main_parts.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc index 5363c224e7..0360a6a19c 100644 --- a/shell/browser/electron_browser_main_parts.cc +++ b/shell/browser/electron_browser_main_parts.cc @@ -495,6 +495,7 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() { // Destroy node platform after all destructors_ are executed, as they may // invoke Node/V8 APIs inside them. node_debugger_->Stop(); + node_env_.reset(); js_env_->OnMessageLoopDestroying(); fake_browser_process_->PostMainMessageLoopRun();