From 9edfbab89fc3e369d08331a0df9dae1e72e95979 Mon Sep 17 00:00:00 2001 From: Ryohei Ikegami Date: Tue, 28 Mar 2017 19:58:58 +0900 Subject: [PATCH] Add comment why defaultPrevented = false --- lib/browser/guest-window-manager.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/browser/guest-window-manager.js b/lib/browser/guest-window-manager.js index 77777ae211..e06dd27d20 100644 --- a/lib/browser/guest-window-manager.js +++ b/lib/browser/guest-window-manager.js @@ -247,6 +247,8 @@ ipcMain.on('ELECTRON_GUEST_WINDOW_MANAGER_INTERNAL_WINDOW_OPEN', function (event if ((event.sender.isGuest() && !event.sender.allowPopups) || event.defaultPrevented) { if (newGuest !== undefined && newGuest !== null) { if (options.webContents === newGuest.webContents) { + // the webContents is not changed, so set defaultPrevented to false to + // stop the callers of this event from destroying the webContents. event.defaultPrevented = false } event.returnValue = setupGuest(event.sender, frameName, newGuest, options)