github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: NOTREACHED in content::ChildProcessHost::GetChildPath when enable_plugins=false (#25552)

Browse Source 
Co-authored-by: Milan Burda <milan.burda@gmail.com>
This commit is contained in:
trop[bot]
2020-09-23 10:46:00 +09:00
committed by GitHub
parent a8dc3ae5c2
commit 9ff208f898
5 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
shell/browser/electron_browser_client.cc
View File

@@ -701,10 +701,15 @@ void ElectronBrowserClient::AppendExtraCommandLineSwitches(
content::ChildProcessHost::CHILD_RENDERER);
auto gpu_child_path = content::ChildProcessHost::GetChildPath(
content::ChildProcessHost::CHILD_GPU);
#if BUILDFLAG(ENABLE_PLUGINS)
auto plugin_child_path = content::ChildProcessHost::GetChildPath(
content::ChildProcessHost::CHILD_PLUGIN);
if (program != renderer_child_path && program != gpu_child_path &&
program != plugin_child_path) {
#endif
if (program != renderer_child_path && program != gpu_child_path
#if BUILDFLAG(ENABLE_PLUGINS)
&& program != plugin_child_path
#endif
) {
child_path = content::ChildProcessHost::GetChildPath(
content::ChildProcessHost::CHILD_NORMAL);
CHECK_EQ(program, child_path)

2
shell/browser/extensions/electron_component_extension_resource_manager.cc
View File

@@ -17,7 +17,7 @@
#include "electron/buildflags/buildflags.h"
#if BUILDFLAG(ENABLE_PDF_VIEWER)
#include "chrome/browser/pdf/pdf_extension_util.h"
#include "chrome/browser/pdf/pdf_extension_util.h" // nogncheck
#include "extensions/common/constants.h"
#endif

2
shell/browser/extensions/electron_extension_system.cc
View File

@@ -38,7 +38,7 @@
#include "shell/browser/extensions/electron_extension_loader.h"
#if BUILDFLAG(ENABLE_PDF_VIEWER)
#include "chrome/browser/pdf/pdf_extension_util.h"
#include "chrome/browser/pdf/pdf_extension_util.h" // nogncheck
#endif
using content::BrowserContext;

2
shell/browser/extensions/electron_extensions_api_client.cc
View File

@@ -15,7 +15,7 @@
#include "shell/browser/extensions/electron_messaging_delegate.h"
#if BUILDFLAG(ENABLE_PDF_VIEWER)
#include "components/pdf/browser/pdf_web_contents_helper.h"
#include "components/pdf/browser/pdf_web_contents_helper.h" // nogncheck
#include "shell/browser/electron_pdf_web_contents_helper_client.h"
#endif

2
shell/renderer/renderer_client_base.cc
View File

@@ -54,7 +54,7 @@
#endif
#if BUILDFLAG(ENABLE_PDF_VIEWER)
#include "chrome/renderer/pepper/chrome_pdf_print_client.h"
#include "chrome/renderer/pepper/chrome_pdf_print_client.h" // nogncheck
#include "shell/common/electron_constants.h"
#endif // BUILDFLAG(ENABLE_PDF_VIEWER)