github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-10 07:58:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: crash calling BrowserWindow.removeBrowserView() with destroyed webContents (#38842)

Browse Source 
fix: crash calling removeBrowserView() with destroyed webContents

https://github.com/electron/electron/issues/37642
This commit is contained in:
Shelley Vohr
2023-06-21 21:20:54 +02:00
committed by GitHub
parent ce6fe040fe
commit a00a25376d
3 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
spec/api-browser-view-spec.ts
View File

@@ -257,6 +257,20 @@ describe('BrowserView module', () => {
w.removeBrowserView(view);
}).to.not.throw();
});
it('can be called on a BrowserView with a destroyed webContents', (done) => {
view = new BrowserView();
w.addBrowserView(view);
view.webContents.on('destroyed', () => {
w.removeBrowserView(view);
done();
});
view.webContents.loadURL('data:text/html,hello there').then(() => {
view.webContents.close();
});
});
});
describe('BrowserWindow.getBrowserViews()', () => {