From a25b15bc2ae1ef518e4885e28bc531aac5789b09 Mon Sep 17 00:00:00 2001 From: Caesar Schinas Date: Wed, 24 Jul 2019 18:20:25 +0100 Subject: [PATCH] docs: fix instructions for opting out of dark mode (#19358) 4d8a055 (#19226) introduced incorrect instructions for 'opting out' of dark mode in Electron 7.0.0 and for enabling it on older versions. The boolean values for the `NSRequiresAquaSystemAppearance` key were inverted. --- docs/tutorial/mojave-dark-mode-guide.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/tutorial/mojave-dark-mode-guide.md b/docs/tutorial/mojave-dark-mode-guide.md index 2de7add63a..c1ca37c0cf 100644 --- a/docs/tutorial/mojave-dark-mode-guide.md +++ b/docs/tutorial/mojave-dark-mode-guide.md @@ -5,14 +5,14 @@ for all macOS computers. If your app does have a dark mode, you can make your E follow the system-wide dark mode setting. In macOS 10.15 Catalina, Apple introduced a new "automatic" dark mode option for all macOS computers. In order -for the `isDarkMode` and `Tray` APIs to work correctly in this mode on Catalina you need to either have `NSRequiresAquaSystemAppearance` set to `true` in your `Info.plist` file or be on Electron `>=7.0.0`. +for the `isDarkMode` and `Tray` APIs to work correctly in this mode on Catalina you need to either have `NSRequiresAquaSystemAppearance` set to `false` in your `Info.plist` file or be on Electron `>=7.0.0`. ## Automatically updating the native interfaces "Native Interfaces" include the file picker, window border, dialogs, context menus and more; basically anything where the UI comes from macOS and not your app. The default behavior as of Electron 7.0.0 is to opt in to this automatic theming from the OS. If you wish to opt out you must set the `NSRequiresAquaSystemAppearance` key in the `Info.plist` file -to `false`. Please note that once Electron starts building against the 10.14 SDK it will not be possible for you to opt +to `true`. Please note that once Electron starts building against the 10.14 SDK it will not be possible for you to opt out of this theming. ## Automatically updating your own interfaces