diff --git a/shell/browser/api/electron_api_service_worker_context.cc b/shell/browser/api/electron_api_service_worker_context.cc index 402f900d38..959a87bc68 100644 --- a/shell/browser/api/electron_api_service_worker_context.cc +++ b/shell/browser/api/electron_api_service_worker_context.cc @@ -115,10 +115,10 @@ v8::Local ServiceWorkerContext::GetAllRunningWorkerInfo( gin::DataObjectBuilder builder(isolate); const base::flat_map& info_map = service_worker_context_->GetRunningServiceWorkerInfos(); - for (auto iter = info_map.begin(); iter != info_map.end(); ++iter) { + for (const auto& iter : info_map) { builder.Set( - std::to_string(iter->first), - ServiceWorkerRunningInfoToDict(isolate, std::move(iter->second))); + std::to_string(iter.first), + ServiceWorkerRunningInfoToDict(isolate, std::move(iter.second))); } return builder.Build(); } diff --git a/shell/browser/api/message_port.cc b/shell/browser/api/message_port.cc index 173813354b..4faf28cce4 100644 --- a/shell/browser/api/message_port.cc +++ b/shell/browser/api/message_port.cc @@ -240,8 +240,8 @@ std::vector MessagePort::DisentanglePorts( // Passed-in ports passed validity checks, so we can disentangle them. std::vector channels; channels.reserve(ports.size()); - for (unsigned i = 0; i < ports.size(); ++i) - channels.push_back(ports[i]->Disentangle()); + for (auto port : ports) + channels.push_back(port->Disentangle()); return channels; } diff --git a/shell/common/gin_converters/net_converter.cc b/shell/common/gin_converters/net_converter.cc index f7b6c37b08..4df91635ea 100644 --- a/shell/common/gin_converters/net_converter.cc +++ b/shell/common/gin_converters/net_converter.cc @@ -578,8 +578,7 @@ bool Converter>::FromV8( return false; base::Value::List& list = list_value.GetList(); *out = base::MakeRefCounted(); - for (size_t i = 0; i < list.size(); ++i) { - base::Value& dict_value = list[i]; + for (base::Value& dict_value : list) { if (!dict_value.is_dict()) return false; base::Value::Dict& dict = dict_value.GetDict();