github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-01-09 15:38:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

robustify verify-mksnapshot w.r.t. command-line parameters

Browse Source
This commit is contained in:
Jeremy Apthorp
2019-04-18 14:44:45 -07:00
parent 4f8ebae5bf
commit a49af01411
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
script/verify-mksnapshot.py
View File

@@ -24,10 +24,11 @@ def main():
try: try:
with scoped_cwd(app_path): with scoped_cwd(app_path):
if args.snapshot_files_dir is None: if args.snapshot_files_dir is None:
mkargs = [ get_binary_path('mksnapshot', app_path), \ mkargs = subprocess.check_output(
SNAPSHOT_SOURCE, '--startup_blob', 'snapshot_blob.bin', \ [ 'gn', 'desc', args.build_dir,
'--turbo_instruction_scheduling' ] 'v8:run_mksnapshot_default', 'args' ],
subprocess.check_call(mkargs) cwd=source_root).split('\n')[:-1]
subprocess.check_call(mkargs + [ SNAPSHOT_SOURCE ], cwd=args.build_dir)
print 'ok mksnapshot successfully created snapshot_blob.bin.' print 'ok mksnapshot successfully created snapshot_blob.bin.'
context_snapshot = 'v8_context_snapshot.bin' context_snapshot = 'v8_context_snapshot.bin'
context_snapshot_path = os.path.join(app_path, context_snapshot) context_snapshot_path = os.path.join(app_path, context_snapshot)