github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-02-19 03:14:51 -05:00
Code Issues Packages Projects Releases Wiki Activity

feat: upgrade to Node 12 (#17838)

Browse Source 
* fix: add boringssl backport to support node upgrade

* fix: Update node_includes.h, add DCHECK macros

* fix: Update node Debug Options parser usage

* fix: Fix asar setup

* fix: using v8Util in isolated context

* fix: make "process" available in preload scripts

* fix: use proper options parser and remove setting of _breakFirstLine

_breakFirstLine was being set on the process, but that has changed in node 12 and so is no longer needed. Node will handle it properly when --inspect-brk is provided

* chore: update node dep sha

* fix: process.binding => _linkedBinding in sandboxed isolated preload

* fix: make original-fs work with streams

* build: override node module version

* fix: use _linkedBinding in content_script/init.js

* chore: update node ref in DEPS

* build: node_module_version should be 73
This commit is contained in:
Cheng Zhao
2019-04-26 18:55:12 +09:00
committed by GitHub
parent e1acfffaf8
commit a4fcc32799
15 changed files with 249 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/common/asar.js
View File

@@ -1,7 +1,7 @@
'use strict';
(function () {
const asar = process.binding('atom_common_asar')
const asar = process._linkedBinding('atom_common_asar')
const assert = require('assert')
const { Buffer } = require('buffer')
const childProcess = require('child_process')

10
lib/common/asar_init.js
View File

@@ -1,14 +1,6 @@
'use strict'
/* global source, require */
// Expose fs module without asar support.
// NB: Node's 'fs' and 'internal/fs/streams' have a lazy-loaded circular
// dependency. So to expose the unmodified Node 'fs' functionality here,
// we have to copy both 'fs' *and* 'internal/fs/streams' and modify the
// copies to depend on each other instead of on our asarified 'fs' code.
source['original-fs'].replace("require('internal/fs/streams')", "require('original-fs/streams')")
source['original-fs/streams'].replace("require('fs')", "require('original-fs')")
/* global require */
// Monkey-patch the fs module.
require('electron/js2c/asar').wrapFsWithAsar(require('fs'))