github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-04-10 03:01:51 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: ensure BrowserView bounds are always relative to window (#39605)

Browse Source 
fix: ensure BrowserView bounds are always relative to window
This commit is contained in:
Shelley Vohr
2023-08-23 15:55:31 +02:00
committed by GitHub
parent 522bba3dc6
commit a8999bc529
4 changed files with 70 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
shell/browser/api/electron_api_base_window.cc
View File

@@ -768,10 +768,20 @@ void BaseWindow::AddBrowserView(gin::Handle<BrowserView> browser_view) {
browser_view->SetOwnerWindow(nullptr);
}
// If the user set the BrowserView's bounds before adding it to the window,
// we need to get those initial bounds *before* adding it to the window
// so bounds isn't returned relative despite not being correctly positioned
// relative to the window.
auto bounds = browser_view->GetBounds();
window_->AddBrowserView(browser_view->view());
window_->AddDraggableRegionProvider(browser_view.get());
browser_view->SetOwnerWindow(this);
browser_views_.emplace_back().Reset(isolate(), browser_view.ToV8());
// Recalibrate bounds relative to the containing window.
if (!bounds.IsEmpty())
browser_view->SetBounds(bounds);
}
}