diff --git a/atom/browser/atom_browser_client.cc b/atom/browser/atom_browser_client.cc index 0eb36f8690..2f47a23f66 100644 --- a/atom/browser/atom_browser_client.cc +++ b/atom/browser/atom_browser_client.cc @@ -715,8 +715,8 @@ void AtomBrowserClient::RegisterOutOfProcessServices( #endif } -std::unique_ptr AtomBrowserClient::GetServiceManifestOverlay( - base::StringPiece name) { +base::Optional +AtomBrowserClient::GetServiceManifestOverlay(base::StringPiece name) { ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); int id = -1; if (name == content::mojom::kBrowserServiceName) @@ -725,10 +725,11 @@ std::unique_ptr AtomBrowserClient::GetServiceManifestOverlay( id = IDR_ELECTRON_CONTENT_PACKAGED_SERVICES_MANIFEST_OVERLAY; if (id == -1) - return nullptr; + return base::nullopt; base::StringPiece manifest_contents = rb.GetRawDataResource(id); - return base::JSONReader::Read(manifest_contents); + return service_manager::Manifest::FromValueDeprecated( + base::JSONReader::Read(manifest_contents)); } net::NetLog* AtomBrowserClient::GetNetLog() { diff --git a/atom/browser/atom_browser_client.h b/atom/browser/atom_browser_client.h index 61c5f2e53b..52de6e3231 100644 --- a/atom/browser/atom_browser_client.h +++ b/atom/browser/atom_browser_client.h @@ -138,7 +138,7 @@ class AtomBrowserClient : public content::ContentBrowserClient, bool in_memory, const base::FilePath& relative_partition_path) override; void RegisterOutOfProcessServices(OutOfProcessServiceMap* services) override; - std::unique_ptr GetServiceManifestOverlay( + base::Optional GetServiceManifestOverlay( base::StringPiece name) override; net::NetLog* GetNetLog() override; content::MediaObserver* GetMediaObserver() override; diff --git a/atom/utility/atom_content_utility_client.cc b/atom/utility/atom_content_utility_client.cc index f95c8fffa7..e98741ccb8 100644 --- a/atom/utility/atom_content_utility_client.cc +++ b/atom/utility/atom_content_utility_client.cc @@ -10,6 +10,7 @@ #include "content/public/child/child_thread.h" #include "content/public/common/service_manager_connection.h" #include "content/public/common/simple_connection_filter.h" +#include "content/public/utility/utility_thread.h" #include "services/proxy_resolver/proxy_resolver_service.h" #include "services/proxy_resolver/public/mojom/proxy_resolver.mojom.h" #include "services/service_manager/sandbox/switches.h"