github/electron
1
1
Fork 0
mirror of https://github.com/electron/electron.git synced 2026-05-02 03:00:22 -04:00
Code Issues Packages Projects Releases Wiki Activity

feat: add workingDirectory option to shell.openExternal() (#15065)

Browse Source 
Allows passing `workingDirectory` to the underlying `ShellExecuteW` API on Windows.

the motivation is that by default `ShellExecute` would use the current working directory, which would get locked on Windows and can prevent autoUpdater from working correctly. We need to be able specify a different `workingDirectory` to prevent this situation.
This commit is contained in:
Milan Burda
2018-10-10 22:46:54 +02:00
committed by Alexey Kuzmin
parent 2d186cb31a
commit a9475f3590
7 changed files with 42 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
atom/browser/atom_browser_client.cc
View File

@@ -611,7 +611,7 @@ void OnOpenExternal(const GURL& escaped_url, bool allowed) {
#else
escaped_url,
#endif
true);
platform_util::OpenExternalOptions());
}
void HandleExternalProtocolInUI(